Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use patched version of op-rs that hopefully addresses SUP-148. #544

Merged
merged 4 commits into from
Nov 25, 2024

Conversation

soenkeliebau
Copy link
Member

@soenkeliebau soenkeliebau commented Nov 22, 2024

Description

Please add a description here. This will become the commit message of the merge request later.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Preview Give feedback

Reviewer

Preview Give feedback

Acceptance

Preview Give feedback

soenkeliebau and others added 3 commits November 24, 2024 17:42
Changed Cargo.toml to pull released op-rs version instead of pr branch.
Copy link
Member

@siegfriedweber siegfriedweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@siegfriedweber siegfriedweber added this pull request to the merge queue Nov 25, 2024
Merged via the queue into main with commit 27d7056 Nov 25, 2024
16 of 17 checks passed
@siegfriedweber siegfriedweber deleted the fix/SUP-148 branch November 25, 2024 15:47
@sbernauer
Copy link
Member

I'm currently reviewing the back-port in #545 and I'm a bit confused, is it correct that this did not change a single line of code? ^^

@siegfriedweber
Copy link
Member

I'm currently reviewing the back-port in #545 and I'm a bit confused, is it correct that this did not change a single line of code? ^^

The actual work is done in stackable-operator. The function definition did not change there. So, if an operator just used this function then upgrading stackable-operator was sufficient. If an operator tried to calculate the ServiceAccount name on its own, then changes were necessary.

@sbernauer
Copy link
Member

Awesome, many thanks! I already assumed so, just wanted to be sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants