Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle Builder v2 #578

Merged
merged 62 commits into from
Jul 31, 2024
Merged

Bundle Builder v2 #578

merged 62 commits into from
Jul 31, 2024

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented May 20, 2024

Description

Fixes #577

Tasks

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Reviewer

Acceptance

@nightkr nightkr requested a review from a team July 29, 2024 14:19
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good

CHANGELOG.md Outdated Show resolved Hide resolved
rust/operator-binary/src/controller.rs Show resolved Hide resolved
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@nightkr nightkr enabled auto-merge July 31, 2024 11:57
@nightkr nightkr disabled auto-merge July 31, 2024 12:01
@nightkr nightkr added this pull request to the merge queue Jul 31, 2024
Merged via the queue into main with commit f6c0767 Jul 31, 2024
31 checks passed
@nightkr nightkr deleted the spike/bundle-builder-v2 branch July 31, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to v2 bundle builder
4 participants