Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Add key/value pair validation #615

Closed
wants to merge 10 commits into from
Closed

feat!: Add key/value pair validation #615

wants to merge 10 commits into from

Conversation

Techassi
Copy link
Member

@Techassi Techassi commented Jul 3, 2023 •
edited
Loading

Fixes #614

@Techassi Techassi self-assigned this Jul 3, 2023
@Techassi Techassi mentioned this pull request Jul 3, 2023
Closed
github-actions[bot]
github-actions bot reviewed Jul 3, 2023
View reviewed changes
src/types/label.rs Outdated Show resolved Hide resolved
src/types/label.rs Outdated Show resolved Hide resolved
src/types/label.rs Outdated Show resolved Hide resolved
src/types/label.rs Outdated Show resolved Hide resolved
github-actions[bot]
github-actions bot reviewed Jul 4, 2023
View reviewed changes
src/types/label.rs Outdated Show resolved Hide resolved
src/types/label.rs Outdated Show resolved Hide resolved
src/types/label.rs Outdated Show resolved Hide resolved
src/types/label.rs Outdated Show resolved Hide resolved
src/types/label.rs Outdated Show resolved Hide resolved
src/types/label.rs Outdated Show resolved Hide resolved
github-actions[bot]
github-actions bot reviewed Jul 4, 2023
View reviewed changes
src/types/label.rs Outdated Show resolved Hide resolved
src/types/label.rs Outdated Show resolved Hide resolved
@Techassi Techassi mentioned this pull request Jul 4, 2023
Open
@Techassi Techassi linked an issue Jul 4, 2023 that may be closed by this pull request
Add validation for key/value pairs used in various K8s resources #614
Closed
github-actions[bot]
github-actions bot reviewed Jul 5, 2023
View reviewed changes
src/builder/mod.rs Outdated Show resolved Hide resolved
src/builder/mod.rs Outdated Show resolved Hide resolved
src/builder/pod/volume.rs Outdated Show resolved Hide resolved
src/cluster_resources.rs Outdated Show resolved Hide resolved
src/commons/affinity.rs Outdated Show resolved Hide resolved
src/types/annotation.rs Show resolved Hide resolved
src/builder/meta.rs Outdated Show resolved Hide resolved
src/types/annotation.rs Show resolved Hide resolved
src/types/annotation.rs Show resolved Hide resolved
src/types/annotation.rs Show resolved Hide resolved
github-actions[bot]
github-actions bot reviewed Jul 7, 2023
View reviewed changes
src/builder/pod/mod.rs Outdated Show resolved Hide resolved
src/builder/pod/mod.rs Outdated Show resolved Hide resolved
@Techassi Techassi changed the title feat!: Add label max length enforcements feat!: Add key/value pair validation Jul 7, 2023
@Techassi Techassi marked this pull request as ready for review July 7, 2023 11:31
@sbernauer
Copy link
Member

Haven't looked at the code, but this might be something we can contribute to k8s-openapi, e.g. in the form of a trait for validationand some macro-magic

@Techassi
Copy link
Member Author

Yes, this might be a good thing to do. I Don't have a strong preference - I'm happy to contribute this either here or upstream in k8s-openapi.

@Techassi Techassi mentioned this pull request Oct 30, 2023
Merged
@Techassi Techassi closed this Oct 31, 2023
@Techassi Techassi mentioned this pull request Oct 31, 2023
Merged
@NickLarsenNZ NickLarsenNZ deleted the feature/max-label-length branch May 6, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions github-actions left review comments

Assignees

@Techassi Techassi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add validation for key/value pairs used in various K8s resources
2 participants
@Techassi @sbernauer