fix: Remove string cleaning in error report #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbernauer
previously approved these changes
Jun 21, 2024
There was a problem hiding this comment.
Much better, thanks!
It would be awesome if we could have a short module documentation why we have our custom report and are not using snafu's report.
[nix-shell:~/stackable/stackable-cockpit]$ stackablectl --helm-repo-dev http://foo.bar op i commons
ERROR Go wrapper function go_add_helm_repo encountered an error: Get "http://foo.bar/index.yaml": dial tcp: lookup foo.bar: no such host
at src/helm.rs:388
An unrecoverable error occured: helm error
Caused by these errors (recent errors listed first):
1: failed to add Helm repo (Get "http
[nix-shell:~/stackable/stackable-cockpit]$ target/debug/stackablectl --helm-repo-dev http://foo.bar op i commons
ERROR Go wrapper function go_add_helm_repo encountered an error: Get "http://foo.bar/index.yaml": dial tcp: lookup foo.bar: no such host
at rust/stackable-cockpit/src/helm.rs:388
An unrecoverable error occured: helm error
Caused by these errors (recent errors listed first):
1: failed to add Helm repo (Get "http://foo.bar/index.yaml": dial tcp: lookup foo.bar: no such host)
|
Oh yeah, I can add that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, let's remove the cleaning of error messages, because it hides too much detail. In the future, we should improve how these error messages are rendered in the terminal.