-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade to Bazel 7 #368
Conversation
Current build failure due to bazelbuild/bazel@a76763c Fixed by https://github.com/bazelbuild/rules_apple/releases/tag/3.0.0-rc2
|
Looks like com_github_grpc_grpc isn't happy yet. |
@pcj do you have more pointers about what's broken with it? |
@alexeagle Just looking at the logs from https://github.com/stackb/rules_proto/actions. Maybe it just needed more recent rules_apple as you recently committed. CI has new error though. |
Also was looking at grpc/grpc#35391. Hopefully will work. There should be tests here for virtual imports. |
grpc/grpc@45aecbe is the beginning of "Bazel 7 to the support bazel versions" so trying to upgrade to oldest release containing that. |
Seems like the apple version isn't quite right?
|
Sorry, I hope to come back to this but I'm not sure when I'll get time. If the client we're working for is able to upgrade to Bazel 7 without changes here, then I'll have less reason to prioritize it. |
Our client finished their Bazel 7 upgrade, so this isn't critical for users. Just a housekeeping change for development in the repo. |
No description provided.