Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: api-key manager cleanup and log error on llm call #1077

Conversation

thecodacus
Copy link
Collaborator

some api key manager fix, the keys in UI takes priority, and enable edit even if env key is set.

added error log on llm call on server terminal

@thecodacus thecodacus requested a review from leex279 January 12, 2025 15:31
@leex279
Copy link
Collaborator

leex279 commented Jan 12, 2025

Working for me so far:
image

This is awesome and a feature we really need asap for all users.

Copy link
Collaborator

@leex279 leex279 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can just approve from a functionality standpoint, not if the code quality is good.

But this works for me and is fine :)

@thecodacus
Copy link
Collaborator Author

I can just approve from a functionality standpoint, not if the code quality is good.

quick and dirty fix till finds a better way 😅

@thecodacus thecodacus merged commit fad4197 into stackblitz-labs:main Jan 12, 2025
3 checks passed
JJ-Dynamite pushed a commit to val-x/valenClient that referenced this pull request Jan 13, 2025
…bs#1077)

* fix: api-key manager cleanup and log error on llm call

* log improved
timoa pushed a commit to timoa/bolt.diy that referenced this pull request Jan 21, 2025
…bs#1077)

* fix: api-key manager cleanup and log error on llm call

* log improved
JJ-Dynamite pushed a commit to val-x/valenClient that referenced this pull request Jan 29, 2025
…bs#1077)

* fix: api-key manager cleanup and log error on llm call

* log improved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants