Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: generate valid dev private key #333

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

jbolda
Copy link
Contributor

@jbolda jbolda commented Feb 20, 2025

Motivation

It appears that calls to the simulated GitHub endpoint were failing. However, the octokit instance was failing at creation due to an issue with the private key that was generated for testing purposes. Despite as such, the tests were still passing.

Modifications

  • Adjusted the private key to output as single line string. octokit could then make a valid instance.
  • Removed the code paths which used test as dependency as they were not required.
  • Added a few new org/repo combinations that would be used now that calls were being made to the GitHub simulator.

@Aslemammad Aslemammad merged commit 658e341 into stackblitz-labs:main Feb 21, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants