Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sdk: fix relative import paths in emmited types #1722

Merged
merged 1 commit into from
Jan 25, 2022
Merged

sdk: fix relative import paths in emmited types #1722

merged 1 commit into from
Jan 25, 2022

Conversation

fvsch
Copy link
Contributor

@fvsch fvsch commented Jan 25, 2022

Aims to fix #1721.

  • Explicitly import the VM type and explicitly declare the Promise<VM> return type for functions that return that promise.
  • Other changes in sdk/src/index.ts are Prettier formatting plus a couple stylistic changes.

@EricSimons EricSimons merged commit 7c90bdc into master Jan 25, 2022
@fvsch fvsch deleted the fvsch/sdk-fix-typings-relative-path branch February 10, 2022 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricSimons EricSimons EricSimons approved these changes

@markwhitfeld markwhitfeld Awaiting requested review from markwhitfeld

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SDK typings building error
2 participants
@fvsch @EricSimons