fix(sdk): escape brackets in file paths with embedProject/openProject #2295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fvsch
force-pushed
the
fvsch/sdk-escape-brackets
branch
from
5367c27
to
00b7192
Compare
fvsch
force-pushed
the
fvsch/sdk-escape-brackets
branch
from
00b7192
to
e3fa7d7
Compare
AleksandrSl
approved these changes
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Frameworks such as Next.js and SvelteKit use square brackets in their file-based routing API. For instance a SvelteKit route may use this file path:
With the form posting method used by the
embedProjectandopenProjectmethods, this currently gets turned into the following input name:Which trips up the StackBlitz backend.
This PR turns the
[]characters in file paths, and only those characters, into their corresponding URI-escaped values. The StackBlitz backend will do the corresponding decoding. Note that we do not want toencodeURIComponentthe full file path, because that would break backwards compatibility with StackBlitz Enterprise Edition.