Add cross-origin isolation flag #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamVerschueren
commented
Jul 2, 2024
| "arrowParens": "always", | ||
| "bracketSpacing": true, | ||
| "trailingComma": "es5" | ||
| "printWidth": 100, |
There was a problem hiding this comment.
I ran prettier and it fixed some stuff.
SamVerschueren
commented
Jul 2, 2024
| @@ -19,7 +19,8 @@ | |||
| <body> | |||
| <h1>StackBlitz SDK Examples</h1> | |||
| <ul> | |||
| <li><a href="/examples/open-embed-project-id/">Open and embed a StackBlitz project</a></li> | |||
| <li><a href="/examples/open-embed-project-id/">Open and embed a StackBlitz EngineBlock project</a></li> | |||
| <li><a href="/examples/open-embed-webcontainer/">Open and embed a StackBlitz WebContainer project</a></li> | |||
There was a problem hiding this comment.
Added a new example to test loading WebContainer projects with and without the CORP headers.
SamVerschueren
commented
Jul 2, 2024
| <h1>Open and embed a StackBlitz WebContainer project</h1> | ||
| <div> | ||
| <label> | ||
| <input type="checkbox" name="corp" /> Cross-Origin Isolation |
There was a problem hiding this comment.
Checking and unchecking this checkbox will load the page either with or without the CORP headers making it possible to test how embeds behave in different scenario's.
SamVerschueren
commented
Jul 2, 2024
| frame: HTMLIFrameElement, | ||
| options: EmbedOptions = {} | ||
| ) { | ||
| const allowList = target.allow?.split(';')?.map((key) => key.trim()) ?? []; |
There was a problem hiding this comment.
We copy the allow list which is already part of the iframe, and add cross-origin-isolated if it's not yet there.
diegohaz
referenced
this pull request
in ariakit/ariakit
Jul 6, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@stackblitz/sdk](https://github.com/stackblitz/sdk) | [`1.10.0` -> `1.11.0`](https://renovatebot.com/diffs/npm/@stackblitz%2fsdk/1.10.0/1.11.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>stackblitz/sdk (@​stackblitz/sdk)</summary> ### [`v1.11.0`](https://github.com/stackblitz/sdk/blob/HEAD/CHANGELOG.md#v1110-2024-07-02) [Compare Source](https://github.com/stackblitz/sdk/compare/cd886120d50b49c72c95bbb8093d25e18edf1a45...614e61fe8f50c419ed8414024899e37e69b1f999) - Add cross-origin isolation flag ([https://github.com/stackblitz/sdk/pull/20](https://github.com/stackblitz/sdk/pull/20)) - Fix and test format ([https://github.com/stackblitz/sdk/pull/21](https://github.com/stackblitz/sdk/pull/21)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ariakit/ariakit). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjEuOSIsInVwZGF0ZWRJblZlciI6IjM3LjQyMS45IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
crossOriginIsolatedflag which in turn will set thecorp=1query param when loading the embedded project.It will also add the
cross-origin-isolatedflag to the allow list of the iframe if it's not yet there.