Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sinon): Add @assertive-ts/sinon plugin #118

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Conversation

JoseLion
Copy link
Member

An Assertive.ts plugin to match over Sinon.js spies, stubs, mocks, and fakes. Check the README.md for details on usage and how it should look like 🙂

@JoseLion JoseLion self-assigned this Jan 26, 2024
Copy link
Contributor

@dalejo96 dalejo96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just minor things.

packages/README.md Outdated Show resolved Hide resolved
packages/sinon/src/lib/SinonSpyAssertion.ts Outdated Show resolved Hide resolved
packages/sinon/src/lib/SinonSpyAssertion.ts Outdated Show resolved Hide resolved
packages/sinon/src/lib/SinonSpyAssertion.ts Outdated Show resolved Hide resolved
packages/sinon/src/lib/SinonSpyAssertion.ts Outdated Show resolved Hide resolved
packages/sinon/src/lib/SinonSpyAssertion.ts Outdated Show resolved Hide resolved
packages/sinon/src/lib/SinonSpyCallAssertion.ts Outdated Show resolved Hide resolved
packages/sinon/src/main.ts Show resolved Hide resolved
packages/sinon/test/unit/lib/SinonSpyAssertion.test.ts Outdated Show resolved Hide resolved
packages/README.md Outdated Show resolved Hide resolved
packages/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@ChristianSama ChristianSama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just left a couple of comments

Copy link
Contributor

@dalejo96 dalejo96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@JoseLion JoseLion merged commit ca16230 into main Feb 15, 2024
4 checks passed
@JoseLion JoseLion deleted the feat/sinon-plugin branch February 15, 2024 21:56
@JoseLion
Copy link
Member Author

@all-contributors please add @dalejo96 for review

Copy link
Contributor

@JoseLion

I've put up a pull request to add @dalejo96! 🎉

Copy link

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants