Add template for terranix #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sestrella
reviewed
Feb 26, 2024
sestrella
reviewed
Feb 26, 2024
sestrella
reviewed
Feb 26, 2024
| @@ -50,6 +50,10 @@ | |||
| description = "Using nixpkgs-terraform with devenv"; | |||
| path = ./templates/devenv; | |||
| }; | |||
| terranix = { | |||
oscar-izval
force-pushed
the
terranix-template
branch
from
6235be6
to
d7ceb00
Compare
sestrella
reviewed
Mar 6, 2024
sestrella
reviewed
Mar 6, 2024
templates/default/flake.nix
Outdated
| @@ -14,7 +14,7 @@ | |||
| flake-utils.lib.eachDefaultSystem (system: | |||
| let | |||
| pkgs = nixpkgs.legacyPackages.${system}; | |||
| terraform = nixpkgs-terraform.packages.${system}."1.7.2"; | |||
| terraform = nixpkgs-terraform.packages.${system}."1.7.4"; | |||
There was a problem hiding this comment.
@oscar-izval It appears that there is some room for improvement here. I believe that eventually the update-version.py script should update all templates. What do you think?
There was a problem hiding this comment.
Yeah, that should be easy enough, I'll open an issue to keep track of the idea, thanks!
|
Can you take another look @sestrella? I'd say it's ready for a final review |
sestrella
approved these changes
Mar 7, 2024
|
@oscar-izval nice job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.