Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rethinking boost #1408

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

rethinking boost #1408

wants to merge 17 commits into from

Conversation

huumn
Copy link
Member

@huumn huumn commented Sep 14, 2024

closes #1351
closes #194

This is done. It can be improved but it's good enough imo.

Screenshot 2024-09-18 at 7 41 29 PM
Screenshot 2024-09-18 at 7 41 41 PM
Screenshot 2024-09-18 at 7 42 34 PM
Screenshot 2024-09-18 at 7 43 31 PM

The intent here is to:

  1. make job promotion use boost like normal items
  2. make item "promotion" possible using boost
    • highest boost in territory gets pinned to top
    • when viewing "home" highest boost in all followed territories gets pinned at top
  3. make adding boost not reliant on edits
    • if an item is our own, whether a comment or post, show the lightning bolt flipped horizontally which when pressed opens a modal to apply boost (this way they can work for comments too)

TODO

  • allow jobs to be deleted
  • expire boost after 30 days
  • allow items to be boosted beyond edit window
  • allow highest boosted item in territory to be pinned
  • unify zap/downzap/boost button components/styling
  • comment ranking for boost
  • make sure boost is excluded from top

EXTRA TODO

  • hint if boosted item is high enough to pin it or not
  • review performance and see if there's something better that can be done
  • squash all migrations for this into one

@huumn huumn marked this pull request as ready for review September 18, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant