-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scripts for automated social posting #477
base: master
Are you sure you want to change the base?
Conversation
Can you just insert items into the database manually, and associate them to the ad account? |
I haven't looked through all of the code but my first impression is that I don't think we want to maintain a lot of bash code. Don't get me wrong, I like bash, but not 299 lines of it, lol. Imo, it's a good scripting language for "quick and dirty" solutions for one-time jobs or for one-liners using a clever combination of CLI tools thanks to the UNIX philosophy (do one thing and do it well) where other scripting languages like Python or NodeJS may be more verbose. But I think it's not the right choice for this task here:
Also, why split these into different files? If you really want to go down this path (without guarantees that we will merge this), you should define functions in these different files which you can source in a single bash file. Then you don't need to call one script from the other script. Also, I am not sure if we can install command line tools in the environment in which SN is deployed. I think all of this code should be placed in the worker. |
Yeah, I searched the code and figured out how to do it...just set the |
Lol that was my original plan, but I thought this was supposed to be independent of the SN site. Perhaps being in the worker is independent enough...from the app portion at least? @huumn |
If we do this in the worker, what do you think about adding |
I guess for completeness it's worth mentioning some of the benefits of the bash solution:
Just FWIW....not intending to dig heels in if the sentiment is strong the other way. |
While this technically satisfies the issue, I'd strongly prefer these were written in JS like everything else.
It need not be in the worker, but if it can be if that's easier. Ideally, we'd run this as its own microservice. As for deps, we'd likely only need a twitter api one and some websocket lib that allows us to send events to wss://nostr.mutinywallet.com. I'm going to move this to a draft pending conversion to javascript. @rleed if you're not interested in completing the conversion I can partially compensate you for the work here. You've logically modeled the solution. |
Interested!? More than happy to finish the job! (Honestly it would be nice to have partial compensation now, but I'd also be delighted to take it across the finish line too.) Thanks for weighing in... |
Yeah sorry for the late reply. Been conferencing for the last week. I'm reviewing your other straightforward PRs now and I'll send along funds for them all at once. |
I've added a new container for it and ported the main logic already.
Sounds good. I'm working on that now... |
This is now fully functional! That was fun...
In the end, I'm soo happy we did this in JS. Simply nicer. @ekzyis, you were right from the beginning ;) |
Looks great at a glance! I'm going to deploy some other stuff, but I'll send you the partial sum as discussed along with the other stuff once I've deployed the stuff I've already reviewed. |
Should close #434.
README.md says a lot. This basically just curls the GraphQL api and generates tweets/events from that.Ported to js, see conv below.