Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RADOS gateway usage exporter support #1082

Merged
merged 22 commits into from
Nov 13, 2024
Merged

Add RADOS gateway usage exporter support #1082

merged 22 commits into from
Nov 13, 2024

Conversation

seunghun1ee
Copy link
Member

No description provided.

@seunghun1ee seunghun1ee self-assigned this May 22, 2024
@seunghun1ee seunghun1ee mentioned this pull request May 22, 2024
Closed
@seunghun1ee seunghun1ee changed the title Deploy RADOS gateway usage exporter from SKC WIP: Deploy RADOS gateway usage exporter from SKC May 22, 2024
@Alex-Welsh
Copy link
Contributor

@seunghun1ee what's the status of this PR? It's already a bit stale, can we get it moving again?

@seunghun1ee
Copy link
Member Author

seunghun1ee commented Nov 12, 2024 •
edited
Loading

@Alex-Welsh The playbook and Prometheus template were tested. This was set to WIP because the exporter itself is missing one criteria: Reducing the privileges of the credential that the exporter use.

I can close this and create new PR to Antelope branch if we are okay to move on with one missing criteria.

@Alex-Welsh
Copy link
Contributor

Alex-Welsh commented Nov 12, 2024 •
edited by seunghun1ee
Loading

@Alex-Welsh The playbook and Prometheus template were tested. This was set to WIP because the exporter itself is missing one criteria: Reducing the privileges of the credential that the exporter use.

I can close this and create new PR to Antelope branch if we are okay to move on with one missing criteria.

I see what you mean. Using admin creds isn't ideal but we do it in a lot of places. I don't think it should be a blocker in this instance.

Please do rebase this and change the target branch. Since it's a new feature, I think we should just put it in Caracal

@Alex-Welsh
Copy link
Contributor

Also, please add a release note

@seunghun1ee seunghun1ee changed the base branch from stackhpc/yoga to stackhpc/2024.1 November 12, 2024 13:29
@seunghun1ee
Add playbook for deploying radosgw usage exporter
39cd9fe
@seunghun1ee
Fix regex to include FQDN
d72fdec
@seunghun1ee
Improve playbook with run_once
0451289
@seunghun1ee
Add general condition variable to enable rgw exporter
38e1daa
@seunghun1ee
Add prometheus target template for rgw exporter
4a6b814
@seunghun1ee
Add deploying rgw exporter at service deploy post hook
7ab1048 
This will not run by default as ``stackhpc_enable_radosgw_usage_exporter``
is initially set to false
@seunghun1ee
Fix condition order
a045da6
@seunghun1ee
Delegate to controller to ensure access to openstack
a2b804e
@seunghun1ee
Add option to enable/disable TLS verification
bf0edab
@seunghun1ee
Add option to select port for rgw exporter
dc73026
@seunghun1ee
Add cert copying steps to rgw exporter container
3077f82
@seunghun1ee
Fix typo
5460e2c
@seunghun1ee
Add tag to deploy playbook
288c317
@seunghun1ee
Set openstack auth env automatically
892b6fc
@seunghun1ee
Revert "Add deploying rgw exporter at service deploy post hook"
28a88f4 
This reverts commit 1607da4.
@seunghun1ee seunghun1ee force-pushed the radosgw-usage-exporter-deploy-yoga branch from 0b13351 to 28a88f4 Compare November 12, 2024 13:33
@seunghun1ee seunghun1ee marked this pull request as ready for review November 12, 2024 13:33
@seunghun1ee seunghun1ee requested a review from a team as a code owner November 12, 2024 13:33
@seunghun1ee seunghun1ee changed the title WIP: Deploy RADOS gateway usage exporter from SKC Add RADOS gateway usage exporter support Nov 12, 2024
@seunghun1ee
Copy link
Member Author

@Alex-Welsh I found the way to use ceph_rgw user's ec2 credential instead of admin user.

Alex-Welsh
Alex-Welsh requested changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@Alex-Welsh Alex-Welsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One general change, could you add it as a post-hook to service deploy since the default for stackhpc_enable_radosgw_usage_exporter is false?

etc/kayobe/ansible/deploy-radosgw-usage-exporter.yml Show resolved Hide resolved
etc/kayobe/ansible/deploy-radosgw-usage-exporter.yml Show resolved Hide resolved
etc/kayobe/ansible/deploy-radosgw-usage-exporter.yml Outdated Show resolved Hide resolved
etc/kayobe/ansible/deploy-radosgw-usage-exporter.yml Outdated Show resolved Hide resolved
etc/kayobe/stackhpc-monitoring.yml Outdated Show resolved Hide resolved
@seunghun1ee
Add deploying rgw exporter at service deploy post hook
d6db95a 
This will not run by default as ``stackhpc_enable_radosgw_usage_exporter``
is initially set to false
Alex-Welsh
Alex-Welsh reviewed Nov 13, 2024
View reviewed changes
Copy link
Contributor

@Alex-Welsh Alex-Welsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of nits but almost there

etc/kayobe/ansible/deploy-radosgw-usage-exporter.yml Outdated Show resolved Hide resolved
releasenotes/notes/add-radosgw-usage-exporter-support-93d55c544418b05a.yaml Show resolved Hide resolved
@Alex-Welsh Alex-Welsh enabled auto-merge (squash) November 13, 2024 14:10
@Alex-Welsh Alex-Welsh merged commit 4026c4e into stackhpc/2024.1 Nov 13, 2024
12 checks passed
@Alex-Welsh Alex-Welsh deleted the radosgw-usage-exporter-deploy-yoga branch November 13, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MoteHue MoteHue MoteHue left review comments

@Alex-Welsh Alex-Welsh Alex-Welsh approved these changes

Assignees

@seunghun1ee seunghun1ee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seunghun1ee @Alex-Welsh @MoteHue