Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INFRA-871 Remove angular plugins from Grafana #1388

Merged
merged 3 commits into from
Dec 13, 2024
Merged

INFRA-871 Remove angular plugins from Grafana #1388

merged 3 commits into from
Dec 13, 2024

Conversation

technowhizz
Copy link
Contributor

We are seeing these in the Grafana logs

logger=plugins.validation t=2024-11-27T15:55:24.742127289+02:00 level=error msg="Plugin validation failed" pluginId=grafana-piechart-panel error="angular plugins are not supported"

logger=plugins.validation t=2024-11-27T15:55:24.578288183+02:00 level=error msg="Plugin validation failed" pluginId=gnocchixyz-gnocchi-datasource error="angular plugins are not supported"

This PR removes the offending plugins.

@technowhizz technowhizz self-assigned this Nov 27, 2024
@technowhizz technowhizz requested a review from a team as a code owner November 27, 2024 15:24
@technowhizz technowhizz marked this pull request as draft November 27, 2024 15:28
mnasiadka
mnasiadka previously approved these changes Nov 27, 2024
View reviewed changes
@technowhizz
Copy link
Contributor Author

PR in draft whilst images build

dougszumski
dougszumski previously approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@dougszumski dougszumski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @technowhizz

@technowhizz technowhizz dismissed stale reviews from dougszumski and mnasiadka via 5192fc7 November 28, 2024 14:02
@Alex-Welsh Alex-Welsh added Caracal Targets the Caracal OpenStack release monitoring All things related to observability & telemetry labels Nov 28, 2024
@technowhizz technowhizz force-pushed the grafana-remove-angular-plugins branch from 5192fc7 to 7e09e35 Compare December 13, 2024 10:25
@technowhizz technowhizz force-pushed the grafana-remove-angular-plugins branch from 7e09e35 to cbe37ac Compare December 13, 2024 10:28
@technowhizz technowhizz marked this pull request as ready for review December 13, 2024 10:28
@technowhizz technowhizz changed the title Remove angular plugins from Grafana INFRA-871 Remove angular plugins from Grafana Dec 13, 2024
@dougszumski dougszumski self-requested a review December 13, 2024 13:30
@technowhizz technowhizz force-pushed the grafana-remove-angular-plugins branch from cbe37ac to 213a494 Compare December 13, 2024 15:08
@technowhizz technowhizz merged commit 1b04d74 into stackhpc/2024.1 Dec 13, 2024
12 checks passed
@technowhizz technowhizz deleted the grafana-remove-angular-plugins branch December 13, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougszumski dougszumski dougszumski approved these changes

@mnasiadka mnasiadka Awaiting requested review from mnasiadka

Assignees

@technowhizz technowhizz

Labels
Caracal Targets the Caracal OpenStack release monitoring All things related to observability & telemetry size: s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@technowhizz @dougszumski @mnasiadka @Alex-Welsh