Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle expiration date in regard to changed timezones #667

Conversation

bahkauv70
Copy link
Contributor

No description provided.

@bahkauv70 bahkauv70 force-pushed the fix/stackittpr-89-Setting-a-expiration-date-in-non-UTC-format-prevents-plan-application branch from 6f6a67d to 232365e Compare February 10, 2025 09:31
@bahkauv70 bahkauv70 requested a review from Fyusel February 10, 2025 09:37
@bahkauv70
Copy link
Contributor Author

Additional clarification: If the expiration_time is updated to the same date, but with a different notation, e.g. 2025-12-31T12:00:00+01:00 -> 2025-12-31T11:00:00Z, terraform will issue an update anyway, because:

  • The plan is not empty (it still contains the no-op change to expiration_time)
  • The computed attributes have to be updated
    There doesn't seem to be a officaly way to remove attributes from the plan explicitly. So an empty update is performed, but it won't change the state

@bahkauv70 bahkauv70 merged commit e9af986 into main Feb 11, 2025
3 checks passed
@bahkauv70 bahkauv70 deleted the fix/stackittpr-89-Setting-a-expiration-date-in-non-UTC-format-prevents-plan-application branch February 11, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants