bug fix: fatal error when reading array of length zero in some packets

stackotter · Apr 9, 2021 · f46e08e · f46e08e
1 parent e14d85f
commit f46e08e
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/...project.xcworkspace/xcuserdata/rohanvanklinken.xcuserdatad/UserInterfaceState.xcuserstate b/...project.xcworkspace/xcuserdata/rohanvanklinken.xcuserdatad/UserInterfaceState.xcuserstate
diff --git a/DeltaClient/Sources/Data/Datatypes/NBTCompound.swift b/DeltaClient/Sources/Data/Datatypes/NBTCompound.swift
@@ -204,7 +204,7 @@ struct NBTCompound: CustomStringConvertible {
 
           var list = NBTList(type: listType)
           if length != 0 {
-            for _ in 1...length {
+            for _ in 0..<length {
               let elem = try readTag(ofType: listType)
               list.append(elem.value!)
             }

diff --git a/DeltaClient/Sources/Protocol/Packets/Play/Clientbound/TagsPacket.swift b/DeltaClient/Sources/Protocol/Packets/Play/Clientbound/TagsPacket.swift
@@ -12,13 +12,13 @@ struct TagsPacket: ClientboundPacket {
   static let id: Int = 0x5b
 
   init(from packetReader: inout PacketReader) {
-    for _ in 1...4 {
+    for _ in 0..<4 {
       let length = packetReader.readVarInt()
-      for _ in 1...length {
+      for _ in 0..<length {
         let tagName = packetReader.readString()
         _ = tagName
         let count = packetReader.readVarInt()
-        for _ in 1...count {
+        for _ in 0..<count {
           let entry = packetReader.readVarInt()
           _ = entry
         }