-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Index through chat messages and commands using the arrow keys. #172
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic looks fine to me for the most part, I've just left a bunch of suggestions to help you fix up the code's handling of optionals. By the end of applying all the suggestions you should be able to get rid of all of the force unwraps! (and the code will be much simpler too). Feel free to ask about any of the suggestions in the Discord if they're confusing 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few more suggestions to help you improve at handling optionals, I think you'll find the tip at line 175 very useful :)
?? IS SO USEFUL HAHA Signed-off-by: jxhug <me@jxhug.me>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! I'll just quickly test it out before merging.
It works 🎉 |
Description
You can now index through chat messages and commands using the arrow keys. Fixes #160.
Type of change
Please delete options that are not relevant.
Checklist: