Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement interface of various inventories #196

Merged
merged 15 commits into from
Jun 5, 2024

Conversation

FloofyPlasma
Copy link
Contributor

@FloofyPlasma FloofyPlasma commented May 28, 2024

Description

Implements the interface of various inventories. It doesn't give them full functionality. Please do not merge until TODO is complete!

TODO:

  • Generic_9x1
  • Generic_9x2
  • Generic_9x4
  • Generic_9x5
  • Generic_9x6 (Large chests)
  • Generic_3x3 (Dispenser & Dropper)
  • Anvil
  • Beacon
  • Blast Furnace
  • Brewing Stand
  • Enchantment Table (Needs some type of currently unhandled packet, 0x15 otherwise disconnects.)
  • Furnace
  • Grindstone
  • Hopper
  • Loom
  • Merchant (Villager & Wandering trader)
  • Shulker box
  • Smithing table
  • Smoker
  • Cartography table
  • Stonecutter

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation comments
  • My changes generate no new warnings

Copy link
Owner

@stackotter stackotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left a few quick comments so that you can address them while you're working instead of having to go through a few cycles once the PR's done 😅 just formatting and naming stuff, some of which you already mentioned

Sources/Core/Sources/GUI/WindowType.swift Outdated Show resolved Hide resolved
Sources/Core/Sources/GUI/GUISprite.swift Outdated Show resolved Hide resolved
Sources/Core/Sources/GUI/GUISprite.swift Outdated Show resolved Hide resolved
@FloofyPlasma
Copy link
Contributor Author

04b05a6 implements dropper and dispenser, not beacon. I'm too tired, oops 😅

Copy link
Owner

@stackotter stackotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm 🎉

@stackotter stackotter marked this pull request as ready for review June 5, 2024 09:27
@stackotter stackotter merged commit a796dc8 into stackotter:inventory Jun 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants