-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement interface of various inventories #196
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just left a few quick comments so that you can address them while you're working instead of having to go through a few cycles once the PR's done 😅 just formatting and naming stuff, some of which you already mentioned
04b05a6 implements dropper and dispenser, not beacon. I'm too tired, oops 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm 🎉
Description
Implements the interface of various inventories. It doesn't give them full functionality. Please do not merge until TODO is complete!
TODO:
(Needs some type of currently unhandled packet, 0x15 otherwise disconnects.)Type of change
Checklist: