-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(reconciler): make default group not declarative #1205
Conversation
Skipping CI for Draft Pull Request. |
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaus67, ivan-degtiarenko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
With the introduction of declarative config, the default group, also referred to as the "minimum role", has been made declarative. That means that currently it is not possible to change it going forward, or use a different value than
None
.While only a limited amount of users do use the feature (currently only two instances across all instances use this), we still don't want to break the behavior for them.
Checklist (Definition of Done)
Test manual
ROX-12345: ...
Test manual