Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reconciler): make default group not declarative #1205

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

dhaus67
Copy link

@dhaus67 dhaus67 commented Aug 16, 2023

Description

With the introduction of declarative config, the default group, also referred to as the "minimum role", has been made declarative. That means that currently it is not possible to change it going forward, or use a different value than None.

While only a limited amount of users do use the feature (currently only two instances across all instances use this), we still don't want to break the behavior for them.

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources

Test manual

  • see CI.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 16, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@dhaus67 dhaus67 temporarily deployed to development August 16, 2023 03:37 — with GitHub Actions Inactive
@dhaus67 dhaus67 temporarily deployed to development August 16, 2023 03:37 — with GitHub Actions Inactive
@dhaus67 dhaus67 temporarily deployed to development August 16, 2023 03:37 — with GitHub Actions Inactive
@dhaus67
Copy link
Author

dhaus67 commented Aug 16, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@dhaus67 dhaus67 marked this pull request as ready for review August 16, 2023 10:55
@dhaus67 dhaus67 temporarily deployed to development August 16, 2023 10:55 — with GitHub Actions Inactive
@dhaus67 dhaus67 temporarily deployed to development August 16, 2023 10:55 — with GitHub Actions Inactive
@dhaus67 dhaus67 temporarily deployed to development August 16, 2023 10:55 — with GitHub Actions Inactive
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhaus67, ivan-degtiarenko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dhaus67,ivan-degtiarenko]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dhaus67 dhaus67 merged commit 710ba61 into main Aug 16, 2023
12 checks passed
@dhaus67 dhaus67 deleted the master-dh/fix-default-group branch August 16, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants