Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-19330: Add second declarative config mount point to central CR #1223

Merged

Conversation

ivan-degtiarenko
Copy link
Contributor

@ivan-degtiarenko ivan-degtiarenko commented Aug 28, 2023

Description

This PR adds a second declarative config mount point to ACSCS centrals.

The secret referenced here will not be created by reconciler, but rather manually and only when customer requests multiple orgs support. In that case cloud-service-manual-declarative-configs secret will be created and populated with the corresponding auth provider configuration.

The reasons to introduce separate secret here:

  • Want to separate ownership - cloud-service-sensible-declarative-configs contents are controlled only by fleetshard-sync, let's keep it that way
  • It's easier to identify if declarative configuration was manually changed if secret is separate

Ideally, I would like to name secrets cloud-service-reconciled-declarative-configs and cloud-service-manual-declarative-configs, however, migrating existing secret names looks like a non-trivial task not worth pursuing.

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources

Test manual

  1. CI is sufficient

@ivan-degtiarenko ivan-degtiarenko temporarily deployed to development August 28, 2023 14:45 — with GitHub Actions Inactive
@ivan-degtiarenko ivan-degtiarenko temporarily deployed to development August 28, 2023 14:45 — with GitHub Actions Inactive
@ivan-degtiarenko ivan-degtiarenko temporarily deployed to development August 28, 2023 14:45 — with GitHub Actions Inactive
@parametalol parametalol self-requested a review August 28, 2023 15:06
Copy link
Contributor

@parametalol parametalol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, provided with explanation that the automated tests cover the usecase.

Under condition that the CI tests pass.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0x656b694d, ivan-degtiarenko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ivan-degtiarenko
Copy link
Contributor Author

/retest

@ivan-degtiarenko ivan-degtiarenko merged commit 49272f5 into main Aug 28, 2023
8 checks passed
@ivan-degtiarenko ivan-degtiarenko deleted the ivan/ROX-19330-manual-declarative-config-mount branch August 28, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants