ROX-19013: Add central YAML to API #1232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludydoo
changed the title
kurlov
approved these changes
Sep 4, 2023
SimonBaeumer
requested changes
Sep 5, 2023
openapi/fleet-manager-private.yaml
Outdated
| @@ -241,6 +241,8 @@ components: | |||
| spec: | |||
| type: object | |||
| properties: | |||
| centralYAML: | |||
There was a problem hiding this comment.
Could the name be a bit more explicit that it mentions it is the CR?
Suggested change
| centralYAML: | |
| centralCRYAML: |
ludydoo
force-pushed
the
ROX-19013-add-central-yaml-to-api
branch
from
b2b6115
to
621c8ec
Compare
SimonBaeumer
approved these changes
Sep 11, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kurlov, ludydoo, SimonBaeumer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding the
centralYAMLproperty to themanagedCentralsfor use with the gitops featureChecklist (Definition of Done)
Unit and integration tests addedAdded test description underTest manualDocumentation added if necessary (i.e. changes to dev setup, test execution, ...)CI and all relevant tests are passingAdd the ticket number to the PR title if available, i.e.ROX-12345: ...Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.Add secret to app-interface Vault or Secrets Manager if necessaryRDS changes were e2e tested manuallyCheck AWS limits are reasonable for changes provisioning new resources