ROX-19558: Mount gitops config to Fleet Manager #1241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludydoo
reviewed
Sep 6, 2023
| @@ -1152,6 +1152,9 @@ objects: | |||
| - name: fleet-manager-dataplane-cluster-configuration-staging | |||
| mountPath: /config/dataplane-cluster-configuration-staging.yaml | |||
| subPath: dataplane-cluster-configuration-staging.yaml | |||
| - name: gitops-config | |||
| mountPath: /config/gitops-config | |||
| subPath: gitops-config | |||
There was a problem hiding this comment.
Should this be stage/prod.yaml ?
There was a problem hiding this comment.
No, it's already mapped correctly to the clusters ( e.g. stage config passed to stage and prod config passed to the prod cluster)
SimonBaeumer
requested changes
Sep 8, 2023
SimonBaeumer
requested changes
Sep 11, 2023
SimonBaeumer
approved these changes
Sep 12, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kurlov, SimonBaeumer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kurlov
deleted the
akurlov/ROX-19558_mount_gitops_config_to_fleet_manager
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
gitops-config-filewhich later can be used to parse gitops config in fleet manager. This file represents configmap from gitops repositoryChecklist (Definition of Done)
- [ ] Unit and integration tests added- [ ] Added test description underTest manual- [ ] Documentation added if necessary (i.e. changes to dev setup, test execution, ...)ROX-12345: ...- [ ] Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.~- [ ] Add secret to app-interface Vault or Secrets Manager if necessary~~
- [ ] RDS changes were e2e tested manually- [ ] Check AWS limits are reasonable for changes provisioning new resourcesTest manual
N/A