Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(probe): improve probe logging #1243

Merged
merged 1 commit into from
Sep 7, 2023
Merged

fix(probe): improve probe logging #1243

merged 1 commit into from
Sep 7, 2023

Conversation

stehessel
Copy link
Contributor

@stehessel stehessel commented Sep 6, 2023 •
edited
Loading

Description

Couple of small fixes for the probe logging.

@stehessel stehessel temporarily deployed to development September 6, 2023 21:35 — with GitHub Actions Inactive
@stehessel stehessel temporarily deployed to development September 6, 2023 21:35 — with GitHub Actions Inactive
@stehessel stehessel temporarily deployed to development September 6, 2023 21:35 — with GitHub Actions Inactive
@stehessel stehessel requested a review from a team September 6, 2023 21:36
@stehessel stehessel temporarily deployed to development September 6, 2023 21:44 — with GitHub Actions Inactive
@stehessel stehessel temporarily deployed to development September 6, 2023 21:44 — with GitHub Actions Inactive
@stehessel stehessel temporarily deployed to development September 6, 2023 21:44 — with GitHub Actions Inactive
@stehessel stehessel changed the title fix(probe): copy&paste in log fix(probe): improve probe logging Sep 6, 2023
@openshift-ci openshift-ci bot added the lgtm label Sep 7, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 7, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 0x656b694d, stehessel
Once this PR has been reviewed and has the lgtm label, please assign kovayur for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stehessel stehessel merged commit 6a4e305 into main Sep 7, 2023
8 checks passed
@stehessel stehessel deleted the fix-type-probe-log branch September 7, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parametalol parametalol parametalol approved these changes

Assignees

@parametalol parametalol

Labels
lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stehessel @parametalol