Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

obscure data in fleetshard-sync status logs #1253

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

johannes94
Copy link
Contributor

@johannes94 johannes94 commented Sep 12, 2023

Description

To keep logs more clean we remove logged encrypted secrets before info logging the status of a reconciliation.

Checklist (Definition of Done)

  • [ ] Unit and integration tests added
  • [ ] Added test description under Test manual
  • [ ] Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • [ ] CI and all relevant tests are passing
  • [ ] Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • [ ] Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • [ ] Add secret to app-interface Vault or Secrets Manager if necessary
  • [ ] RDS changes were e2e tested manually
  • [ ] Check AWS limits are reasonable for changes provisioning new resources

Test manual

CI is sufficient.

# To run tests locally run:
make db/teardown db/setup db/migrate
make ocm/setup OCM_OFFLINE_TOKEN=<ocm-offline-token> OCM_ENV=development
make verify lint binary test test/integration

@johannes94 johannes94 temporarily deployed to development September 12, 2023 08:28 — with GitHub Actions Inactive
@johannes94 johannes94 temporarily deployed to development September 12, 2023 08:28 — with GitHub Actions Inactive
@johannes94 johannes94 temporarily deployed to development September 12, 2023 08:28 — with GitHub Actions Inactive
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johannes94, vladbologa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [johannes94,vladbologa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@johannes94 johannes94 merged commit 9b50f74 into main Sep 12, 2023
8 checks passed
@johannes94 johannes94 deleted the jmalsam/obscure-data-in-status-logs branch September 12, 2023 15:12
@johannes94 johannes94 mentioned this pull request Sep 22, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants