Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-19692: Add a release preparation workflow. #1284

Merged
merged 1 commit into from
Sep 21, 2023
Merged

ROX-19692: Add a release preparation workflow. #1284

merged 1 commit into from
Sep 21, 2023

Conversation

porridge
Copy link
Collaborator

@porridge porridge commented Sep 19, 2023

Description

A workflow to be triggered manually to prepare a PR to be merged to stage branch as part of the release.

Inspired by a similar workflow in the observability-artifacts repo, but with support for specifying a commit or branch.

Once merged, I will clone the PR to the AWS config repo.

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...): Updating release checklist in progress
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources

Test manual

Tested quite extensively in my fork. Example PR.

@porridge porridge temporarily deployed to development September 19, 2023 11:23 — with GitHub Actions Inactive
@porridge porridge temporarily deployed to development September 19, 2023 11:23 — with GitHub Actions Inactive
@porridge porridge temporarily deployed to development September 19, 2023 11:23 — with GitHub Actions Inactive
@porridge porridge temporarily deployed to development September 19, 2023 11:35 — with GitHub Actions Inactive
@porridge porridge temporarily deployed to development September 19, 2023 11:35 — with GitHub Actions Inactive
@porridge porridge temporarily deployed to development September 19, 2023 11:35 — with GitHub Actions Inactive
@porridge porridge temporarily deployed to development September 19, 2023 11:43 — with GitHub Actions Inactive
@porridge porridge temporarily deployed to development September 19, 2023 11:43 — with GitHub Actions Inactive
@porridge porridge temporarily deployed to development September 19, 2023 11:43 — with GitHub Actions Inactive
@porridge porridge marked this pull request as draft September 19, 2023 12:40
@porridge
Copy link
Collaborator Author

Sorry, not ready to review yet after all..

@porridge porridge temporarily deployed to development September 21, 2023 07:11 — with GitHub Actions Inactive
@porridge porridge temporarily deployed to development September 21, 2023 07:11 — with GitHub Actions Inactive
@porridge porridge temporarily deployed to development September 21, 2023 07:11 — with GitHub Actions Inactive
@porridge porridge temporarily deployed to development September 21, 2023 07:31 — with GitHub Actions Inactive
@porridge porridge temporarily deployed to development September 21, 2023 07:31 — with GitHub Actions Inactive
@porridge porridge temporarily deployed to development September 21, 2023 07:31 — with GitHub Actions Inactive
@porridge porridge marked this pull request as ready for review September 21, 2023 07:32
@porridge porridge temporarily deployed to development September 21, 2023 07:32 — with GitHub Actions Inactive
@porridge porridge temporarily deployed to development September 21, 2023 07:34 — with GitHub Actions Inactive
@porridge porridge temporarily deployed to development September 21, 2023 07:34 — with GitHub Actions Inactive
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ludydoo, porridge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@porridge porridge merged commit e650482 into main Sep 21, 2023
8 of 9 checks passed
@porridge porridge deleted the prep-branch2 branch September 21, 2023 08:12
kovayur added a commit that referenced this pull request Sep 26, 2023
* Use Openshift golang-1.20 builder image (#1275)

* Add kind cluster type (#1256)

* Refactor operator config to use field.Error (#1276)

* fix typo causing skip of DNS creation on restore (#1277)

* ROX-19718: Add flag for fleetmanager gitops (#1283)

* Specify reconcile interval in workers (#1265)

* Add request body to rotate-secrets endpoint (#1272)

* Disable automounting for egress proxy (#1286)

* ROX-19808: Remove GitOps admin handler (#1290)

Remove GitOps admin handler

* ROX-19692: Add a release preparation workflow. (#1284)

Prepare release workflow.

* ROX-19735 - add operator configs to gitops (#1278)

* ROX-19692: New workflow to auto-create production merge PRs. (#1291)

New workflow to auto-create production merge PRs.

* ROX-19810: Bump controller-runtime and stackrox deps (#1292)

* Bump controller-runtime and stackrox deps

* Bump openshift/api

* Call /current_account before reserving quota (#1289)

* Remove multi target build (#1259)

* fixed restore endpoint (#1298)

* ROX-19281: Fix nil pointer dereference in E2E tests when Central is not ready (#1216)

* Rename ACSMS -> ACSCS in dev scripts (#1252)

* Log result of current_account call execution (#1297)

* Cleanup errors.go (#1299)

---------

Co-authored-by: Vlad Bologa <vbologa@redhat.com>
Co-authored-by: Simon Bäumer <baeumer@pm.me>
Co-authored-by: Johannes Malsam <60240743+johannes94@users.noreply.github.com>
Co-authored-by: Ludovic Cleroux <ludydoo@gmail.com>
Co-authored-by: Ivan Degtiarenko <78353299+ivan-degtiarenko@users.noreply.github.com>
Co-authored-by: Alex Rukletsov <alexr@redhat.com>
Co-authored-by: Marcin Owsiany <porridge@redhat.com>
Co-authored-by: Aleksandr Kurlov <sasha.kurlov@gmail.com>
Co-authored-by: Yury Kovalev <8366110+kovayur@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants