Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-20268 Support running E2E tests on GKE #1371

Merged
merged 2 commits into from
Oct 20, 2023
Merged

Conversation

mclasmeier
Copy link
Contributor

Description

This PR integrates support for deploying the E2E test suite to GKE (via infra GKE, for example). The major puzzle piece for this was implementing a mechanism for propagating tenant image pull secrets into tenant namespaces for pulling
images from a private Quay repository.

Also: Version bump golangci-linter, because the old version was throwing
errors.

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources

Test manual

TODO: Add manual testing efforts

# To run tests locally run:
make db/teardown db/setup db/migrate
make ocm/setup OCM_OFFLINE_TOKEN=<ocm-offline-token> OCM_ENV=development
make verify lint binary test test/integration

Moritz Clasmeier added 2 commits October 13, 2023 10:56
propagating tenant image pull secrets into tenant namespaces for pulling
images from a private Quay repository).
Version bump golangci-linter, because the old version was throwing
errors.
@mclasmeier mclasmeier temporarily deployed to development October 17, 2023 09:47 — with GitHub Actions Inactive
@mclasmeier mclasmeier temporarily deployed to development October 17, 2023 09:47 — with GitHub Actions Inactive
@mclasmeier mclasmeier temporarily deployed to development October 17, 2023 09:47 — with GitHub Actions Inactive
@mclasmeier mclasmeier changed the title Support running E2E tests on GKE ROX-20268 Support running E2E tests on GKE Oct 17, 2023
@mclasmeier
Copy link
Contributor Author

I suggest to merge this only after the GitOps feature is rolled out (@SimonBaeumer).
Just to be on the safe side when it comes to CI related changes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kovayur, mclasmeier, SimonBaeumer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [SimonBaeumer,kovayur,mclasmeier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mclasmeier mclasmeier merged commit 39cdb8d into main Oct 20, 2023
8 checks passed
@mclasmeier mclasmeier deleted the mc/support-infra-gke branch October 20, 2023 08:16
SimonBaeumer added a commit that referenced this pull request Oct 20, 2023
SimonBaeumer added a commit that referenced this pull request Oct 20, 2023
kovayur pushed a commit that referenced this pull request Jan 17, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants