Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add tests for route service #1382

Merged
merged 2 commits into from
Nov 2, 2023
Merged

test: add tests for route service #1382

merged 2 commits into from
Nov 2, 2023

Conversation

rhybrillou
Copy link
Contributor

Description

New tests for the route service

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources

Test manual

TODO: Add manual testing efforts

# To run tests locally run:
make db/teardown db/setup db/migrate
make ocm/setup OCM_OFFLINE_TOKEN=<ocm-offline-token> OCM_ENV=development
make verify lint binary test test/integration

@rhybrillou rhybrillou temporarily deployed to development October 19, 2023 13:33 — with GitHub Actions Inactive
@rhybrillou rhybrillou temporarily deployed to development October 19, 2023 13:33 — with GitHub Actions Inactive
@rhybrillou rhybrillou temporarily deployed to development October 19, 2023 13:33 — with GitHub Actions Inactive
Namespace: testNamespace,
},
Data: map[string][]byte{
"ca.pem": {'T', 'h', 'i', 's', ' ', 'i', 's', ' ', 'a', ' ',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"ca.pem": {'T', 'h', 'i', 's', ' ', 'i', 's', ' ', 'a', ' ',
"ca.pem": []byte("This is a dummy non-pem payload for CA")

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 30, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: janisz, rhybrillou
Once this PR has been reviewed and has the lgtm label, please assign kovayur for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Nov 2, 2023

New changes are detected. LGTM label has been removed.

@rhybrillou rhybrillou temporarily deployed to development November 2, 2023 08:06 — with GitHub Actions Inactive
@rhybrillou rhybrillou temporarily deployed to development November 2, 2023 08:06 — with GitHub Actions Inactive
@rhybrillou rhybrillou temporarily deployed to development November 2, 2023 08:06 — with GitHub Actions Inactive
@rhybrillou rhybrillou temporarily deployed to development November 2, 2023 11:30 — with GitHub Actions Inactive
@rhybrillou rhybrillou temporarily deployed to development November 2, 2023 11:30 — with GitHub Actions Inactive
@rhybrillou rhybrillou temporarily deployed to development November 2, 2023 11:30 — with GitHub Actions Inactive
@rhybrillou
Copy link
Contributor Author

/retest

@rhybrillou rhybrillou merged commit 449b5de into main Nov 2, 2023
8 checks passed
@rhybrillou rhybrillou deleted the yann/test_route_service branch November 2, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants