Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape linebreaks in json #1394

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Escape linebreaks in json #1394

merged 2 commits into from
Oct 24, 2023

Conversation

kovayur
Copy link
Contributor

@kovayur kovayur commented Oct 20, 2023

Description

Replace all newlines with '\n' symbol as the line breaks are not supported in JSON

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources

Test manual

TODO: Add manual testing efforts

# To run tests locally run:
make db/teardown db/setup db/migrate
make ocm/setup OCM_OFFLINE_TOKEN=<ocm-offline-token> OCM_ENV=development
make verify lint binary test test/integration

@kovayur kovayur requested a review from ebensh October 20, 2023 15:10
@kovayur kovayur temporarily deployed to development October 20, 2023 15:10 — with GitHub Actions Inactive
@kovayur kovayur temporarily deployed to development October 20, 2023 15:10 — with GitHub Actions Inactive
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ebensh, kovayur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm label Oct 23, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 23, 2023

New changes are detected. LGTM label has been removed.

@kovayur kovayur temporarily deployed to development October 23, 2023 10:57 — with GitHub Actions Inactive
@kovayur kovayur temporarily deployed to development October 23, 2023 11:07 — with GitHub Actions Inactive
@kovayur kovayur temporarily deployed to development October 23, 2023 11:07 — with GitHub Actions Inactive
@kovayur kovayur merged commit d3ebc20 into main Oct 24, 2023
7 checks passed
@kovayur kovayur deleted the yury/escape_linebreaks branch October 24, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants