Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-20542: disable http/2 in operator kube-rbac-proxy to mitigate CVE-2023-44487 #1425

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

vladbologa
Copy link
Contributor

@vladbologa vladbologa commented Oct 31, 2023

Description

Because the operator is now installed with a Helm chart, ACS CS will not pick up this change from the next ACS releases, so I'll do it manually (for now). The reasoning for the change is documented here

I'm also switching to the downstream kube-rbac-proxy image, because we're currently using downstream ACS images.

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources

Test manual

I verified that the image supports the new --http2-disable flag by running:
docker run --rm registry.redhat.io/openshift4/ose-kube-rbac-proxy:v4.13 --http2-disable

# To run tests locally run:
make db/teardown db/setup db/migrate
make ocm/setup OCM_OFFLINE_TOKEN=<ocm-offline-token> OCM_ENV=development
make verify lint binary test test/integration

@vladbologa vladbologa temporarily deployed to development October 31, 2023 10:37 — with GitHub Actions Inactive
@vladbologa vladbologa temporarily deployed to development October 31, 2023 10:37 — with GitHub Actions Inactive
@vladbologa vladbologa temporarily deployed to development October 31, 2023 10:37 — with GitHub Actions Inactive
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kurlov, vladbologa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vladbologa vladbologa merged commit 36b9ae1 into main Oct 31, 2023
8 checks passed
@vladbologa vladbologa deleted the vbologa/rbac-proxy-disable-http2 branch October 31, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants