Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache rendered centrals v2 #1435

Merged
merged 6 commits into from
Nov 6, 2023
Merged

Cache rendered centrals v2 #1435

merged 6 commits into from
Nov 6, 2023

Conversation

ludydoo
Copy link
Collaborator

@ludydoo ludydoo commented Nov 6, 2023

Changes:

  • Remove the gitops service. Replace with a function without receiver.
  • Add a function to the managedCentralPresenter to be able to render multiple centrals concurrently. (Moved that from the handler)
  • Added a cache to store the rendered central YAML, keyed by central ID.

Copy link
Contributor

openshift-ci bot commented Nov 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kurlov, ludydoo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ludydoo ludydoo merged commit 8c659a5 into main Nov 6, 2023
8 checks passed
@ludydoo ludydoo deleted the cache-rendered-centrals-v2 branch November 6, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants