Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable OpenShift monitoring for internal Centrals #1447

Merged
merged 4 commits into from
Nov 9, 2023

Conversation

stehessel
Copy link
Contributor

Description

This changes disables OpenShift monitoring for internal Centrals. This is done for these reasons:

  • Probe instances are cleaned up immediately, so there is no need for any monitoring.
  • Since probe instances are created very frequently, the collected metrics ramp up Prometheus storage.
  • Prevent sending useless metrics to Telemeter once that is enabled.

Note that we still collect kube metrics, this just disables the metrics that are emitted by Central itself and collected by OpenShift monitoring.

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources

Test manual

CI

Copy link
Contributor

openshift-ci bot commented Nov 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ludydoo, stehessel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 9, 2023
@stehessel stehessel merged commit cf41d96 into main Nov 9, 2023
8 checks passed
@stehessel stehessel deleted the disable-monitoring-for-internal-centrals branch November 9, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants