Remove nodeSelector for logging operator collector #1501
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With
nodeSelector
defined, collectors will be deployed only on nodes specified by that option. In the case of logging collectors, it is a DaemonSet, and we should have a collector pod running on every cluster node.This PR is a follow-up on #1499
This issue was discovered on the integration cluster after checking the status of the deployment of the previous PR.
Checklist (Definition of Done)
[ ] Unit and integration tests addedTest manual
[ ] Documentation added if necessary (i.e. changes to dev setup, test execution, ...)[ ] Add the ticket number to the PR title if available, i.e.ROX-12345: ...
[ ] Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.[ ] Add secret to app-interface Vault or Secrets Manager if necessary[ ] RDS changes were e2e tested manually[ ] Check AWS limits are reasonable for changes provisioning new resourcesTest manual
The same testing was done similar to PR: #1499
helm template rhacs-terraform-logging --debug --namespace rhacs --values ./acs-terraform-logging-values.yaml . | yq 'select(document_index == 8) | .spec'
Got result: