Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nodeSelector for logging operator collector #1501

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

mtodor
Copy link
Contributor

@mtodor mtodor commented Nov 23, 2023

Description

With nodeSelector defined, collectors will be deployed only on nodes specified by that option. In the case of logging collectors, it is a DaemonSet, and we should have a collector pod running on every cluster node.

This PR is a follow-up on #1499

This issue was discovered on the integration cluster after checking the status of the deployment of the previous PR.

Checklist (Definition of Done)

  • [ ] Unit and integration tests added
  • Added test description under Test manual
  • [ ] Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • [ ] Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • [ ] Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • [ ] Add secret to app-interface Vault or Secrets Manager if necessary
  • [ ] RDS changes were e2e tested manually
  • [ ] Check AWS limits are reasonable for changes provisioning new resources

Test manual

The same testing was done similar to PR: #1499

  1. Remove nodeSelector from test values.yaml
  2. Run helm template rhacs-terraform-logging --debug --namespace rhacs --values ./acs-terraform-logging-values.yaml . | yq 'select(document_index == 8) | .spec'

Got result:

managementState: "Managed"
collection:
  tolerations:
    - effect: NoSchedule
      key: node-role.kubernetes.io/acscs-infra
      operator: Exists
  type: "fluentd"
  fluentd: {}

Copy link
Contributor

openshift-ci bot commented Nov 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ludydoo, mtodor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mtodor
Copy link
Contributor Author

mtodor commented Nov 23, 2023

/retest-required

@mtodor mtodor merged commit 51bc727 into main Nov 23, 2023
8 checks passed
@mtodor mtodor deleted the mtodor/fix-logging-collector-on-all-nodes branch November 23, 2023 14:12
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants