Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollback helm-operator to v1.33.0 #1694

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Conversation

kovayur
Copy link
Contributor

@kovayur kovayur commented Mar 8, 2024

Description

It looks like v1.34.0 is broken. The reconciliation stopped working after merging #1687

Related issues:

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources
  • (If applicable) Changes to the dp-terraform Helm values have been reflected in the addon on integration environment

Test manual

No testing performed

Copy link
Contributor

openshift-ci bot commented Mar 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kovayur, kurlov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kovayur
Copy link
Contributor Author

kovayur commented Mar 8, 2024

/override ci/prow/e2e

Copy link
Contributor

openshift-ci bot commented Mar 8, 2024

@kovayur: Overrode contexts on behalf of kovayur: ci/prow/e2e

In response to this:

/override ci/prow/e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kovayur
Copy link
Contributor Author

kovayur commented Mar 8, 2024

E2E tests failed due to an error unrelated to the change.

@kovayur kovayur merged commit 93d51c3 into main Mar 8, 2024
7 checks passed
@kovayur kovayur deleted the yury/rollback-helm-operator branch March 8, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants