ROX-27980: Support argocd reconciliation for routes

[kovayur]

Description

Add support for the routes reconciliation on ArgoCD.
The feature can be now enabled by setting the value centralIngressEnabled to true in the gitops config.
If disabled (default), reconciliation should be performed in fleetshard-sync mode as before.
If enabled, the routes created by fleetshard-sync are deleted and the reconciliation will be performed by tenant-resources (ArgoCD).

Next steps:

1. Enable the feature on dev environment to make E2E tests pass with the new setup.
2. Enable the feature on the rest environments and effectively delete the routes reconciled by fleetshard-sync.
3. Set centralIngressEnabled to true by default in tenant-resources
4. Cleanup the fleetshard-sync source code by removing the switch and code which is responsible for the routes reconciliation.

Checklist (Definition of Done)

• Unit and integration tests added
• Added test description under Test manual
• Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
• CI and all relevant tests are passing
• Add the ticket number to the PR title if available, i.e. ROX-12345: ...
• Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
• Add secret to app-interface Vault or Secrets Manager if necessary
• RDS changes were e2e tested manually
• Check AWS limits are reasonable for changes provisioning new resources
• (If applicable) Changes to the dp-terraform Helm values have been reflected in the addon on integration environment

Test manual

TODO: Add manual testing efforts

# To run tests locally run:
make db/teardown db/setup db/migrate
make ocm/setup
make verify lint binary test test/integration

[ludydoo]

Seems there is something wrong here. If the secret doesn't exist, it will never call ensureSecretExists. Or am I missing something?

Suggested change

	if apiErrors.IsNotFound(err) {
	centralTLSSecretFound = false // pragma: allowlist secret
	}
	return centralTLSSecretFound, err
	if apiErrors.IsNotFound(err) {
	centralTLSSecretFound = false // pragma: allowlist secret
	} else {
	return false, err
	}

[kovayur]

The purpose of centralTLSSecretFound is to skip the further reconciliation instead of returning the error

[kovayur]

But we'll return the error in any case, so the code was correct. I simplified it a bit.

[ludydoo]

Suggested change

	return !apiErrors.IsNotFound(err), err
	return false, err

[ludydoo]

Just this one last comment mentioned above, otherwise 🔥

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kovayur, ludydoo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [kovayur,ludydoo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment