Fix wait-for-image polluting stdout #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | jq -r ".tags[0].name" | ||
| CURL_PARAMS+=( "--silent" "--show-error" "--fail" "--location" "$URL" ) | ||
| if [ -n "$QUAY_TOKEN" ]; then | ||
| >&2 gh_log notice "Connecting to Quay with token" |
There was a problem hiding this comment.
Is the stderr redirect necessary now that you run curl | jq outside the block?
There was a problem hiding this comment.
Yes, as we later use the output of find_tag. This means that stdout must be clean
There was a problem hiding this comment.
Without >&2:
$ CI=false GITHUB_STEP_SUMMARY="a" ./release/wait-for-image/wait-for-image.sh stackrox-io/main:4.1.1
Waiting 30 more seconds for stackrox-io/main:4.1.1...
With >&2:
$ CI=false GITHUB_STEP_SUMMARY="a" ./release/wait-for-image/wait-for-image.sh stackrox-io/main:4.1.1
::notice::Connecting to Quay without token
::notice::Image 'stackrox-io/main:4.1.1' has been found on Quay.io.
tommartensen
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this version calling
gh_logdoes not pollute the stdout andcurlcan pass the data tojq.