ROX-17712: Ensure finalizer is present before applying the resources #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
porridge
reviewed
Jun 22, 2023
pkg/reconciler/reconciler.go
Outdated
| @@ -267,7 +267,7 @@ func WithOverrideValues(overrides map[string]string) Option { | |||
| } | |||
| } | |||
|
|
|||
| // WithDependentWatchesEnabled is an Option that configures whether the | |||
There was a problem hiding this comment.
This a noble change, but might be a PITA if we upstream this feature separately.
porridge
reviewed
Jun 22, 2023
SimonBaeumer
approved these changes
Jun 23, 2023
|
for reference: operator-framework/helm-operator-plugins#218 |
Co-authored-by: Marcin Owsiany <porridge@redhat.com>
ludydoo
force-pushed
the
ROX-17712-ensure-finalizer-present
branch
from
4dca9f1 to
4219dea
Compare
ludydoo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.