ROX-18085: Allow custom post-renderer #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johannes94
reviewed
Jul 6, 2023
There was a problem hiding this comment.
@ludydoo I like the simplicity of your solution. It's way easier to understand whats going on compared to the ActionClientGetter interface.
But I think it's not good that there are 2 different approaches to PostRender. Maybe it would be better to extend the interface and it's implementation in some way that allows adding object data similar to what is done here.
helm-operator/pkg/client/actionclient.go
Line 143 in b54aa5c
Didn't find a way to do that easily though, I'm curious what they have to say in the upstream PR.
ludydoo
force-pushed
the
ROX-18085-custom-postrenderer
branch
from
aa0b3fe
to
1fe2446
Compare
johannes94
approved these changes
Jul 11, 2023
pkg/client/actionclient.go
Outdated
| func AppendUpgradeFailureRollbackOptions(opts ...RollbackOption) ActionClientGetterOption { | ||
| return func(getter *actionClientGetter) error { | ||
| getter.upgradeFailureRollbackOpts = append(getter.upgradeFailureRollbackOpts, opts...) | ||
| return nil | ||
| } | ||
| } | ||
|
|
||
| type PostRendererProvider func(rm meta.RESTMapper, kubeClient kube.Interface, obj client.Object) postrender.PostRenderer |
There was a problem hiding this comment.
I don't like to call everything "Getter" but this would keep naming consistent across this package.
Suggested change
| type PostRendererProvider func(rm meta.RESTMapper, kubeClient kube.Interface, obj client.Object) postrender.PostRenderer | |
| type PostRendererGetter func(rm meta.RESTMapper, kubeClient kube.Interface, obj client.Object) postrender.PostRenderer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See operator-framework/helm-operator-plugins#219