-
Notifications
You must be signed in to change notification settings - Fork 679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ARM build options and instructions #1354
Add ARM build options and instructions #1354
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me @dantrevino, thanks for putting this together!
For our part, I think we want to make it so that our cargo build is easily amenable to cross-compilation, and your changes to Cargo.toml (and the accompanying instruction in README.md) serve that purpose well. However, we think that cross compilation instructions and support probably shouldn't be in the main repo itself, and would prefer to link out to them as a community supported documentation.
So this is my request: can you drop README-CROSS-COMPILE from this PR, and instead host it somewhere (perhaps your own GitHub repo?) that we can link out to from README.md ?
Move community cross-compiling instructions to 'Community' section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me, thanks for the updates @dantrevino !
Can you merge the latest master
into your branch? I want to make sure that the CI will pass on this PR.
Doh! Sorry @kantai. Done. |
Would love to see this merged if possible. We have a forum user trying to setup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @dantrevino!
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Cargo.toml changes:
Documentation changes:
cargo build
continues to work the same way!fixes #1278