Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ARM build options and instructions #1354

Merged
merged 4 commits into from
Apr 2, 2020

Conversation

dantrevino
Copy link
Contributor

@dantrevino dantrevino commented Mar 26, 2020

Cargo.toml changes:

  • made sha2 and sha2-asm "optional" dependencies.
  • moved [features] section to the bottom for readability
  • sha2-asm is added to the "default" build feature
  • sha2 is added to a new "aarch64" build "feature"

Documentation changes:

  • cargo build continues to work the same way!
  • updated README.md to reflect build instructions and cautions for aarch64 support (cargo build --features "aarch64" --no-default-features).
  • added a README-CROSS-COMPILE.md - build instructions for cross-compiling to low memory devices.

fixes #1278

@CLAassistant
Copy link

CLAassistant commented Mar 26, 2020

CLA assistant check
All committers have signed the CLA.

@jcnelson jcnelson requested review from kantai and jcnelson March 26, 2020 14:40
Copy link
Member

@kantai kantai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me @dantrevino, thanks for putting this together!

For our part, I think we want to make it so that our cargo build is easily amenable to cross-compilation, and your changes to Cargo.toml (and the accompanying instruction in README.md) serve that purpose well. However, we think that cross compilation instructions and support probably shouldn't be in the main repo itself, and would prefer to link out to them as a community supported documentation.

So this is my request: can you drop README-CROSS-COMPILE from this PR, and instead host it somewhere (perhaps your own GitHub repo?) that we can link out to from README.md ?

Move community cross-compiling instructions to 'Community' section
Copy link
Member

@kantai kantai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me, thanks for the updates @dantrevino !

Can you merge the latest master into your branch? I want to make sure that the CI will pass on this PR.

@dantrevino
Copy link
Contributor Author

Doh! Sorry @kantai. Done.

@hstove
Copy link
Contributor

hstove commented Apr 1, 2020

Would love to see this merged if possible. clarity-js-sdk allows you to build from source, but since these changes are in a forked repo, you can't easily build from source using a git branch.

We have a forum user trying to setup clarity-js-sdk on arm64, and I think they'd have to fork clarity-js-sdk to get this temporarily working with Dan's repo.

Copy link
Member

@jcnelson jcnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @dantrevino!

@kantai kantai merged commit e7bfd31 into stacks-network:master Apr 2, 2020
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Dec 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cargo build fails on Raspberry Pi3B. "Unsupported target architecture" for sha2-asm.
6 participants