Fix signer id use in stackerdb #4451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #4451 +/- ##
==========================================
- Coverage 83.46% 77.52% -5.94%
==========================================
Files 448 448
Lines 324308 324321 +13
==========================================
- Hits 270676 251424 -19252
- Misses 53632 72897 +19265
... and 173 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
xoloki
previously approved these changes
Feb 29, 2024
hstove
previously approved these changes
Feb 29, 2024
kantai
previously approved these changes
Feb 29, 2024
jferrant
force-pushed
the
feat/allow-single-transaction-per-signer
branch
2 times, most recently
from
b93c1e9 to
c533146
Compare
jferrant
changed the base branch from
feat/allow-single-transaction-per-signer
to
next
jferrant
dismissed stale reviews from kantai, hstove, and xoloki
The base branch was changed.
Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
jferrant
force-pushed
the
bugfix/misuse-signer-id-signer-slot-id
branch
from
3208ed2 to
73fd5e0
Compare
kantai
approved these changes
Mar 1, 2024
xoloki
approved these changes
Mar 1, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my massive PR, I aaccidentally conflated signer id and signer slot id. this did not break tests because we happened to have everything line up (odds are we ALWAYS will have everything line up since the reward set is used to buidl stackerdb, but this will make sure we do not rely on this)