Chore: remove infinite loop in signer during tests #5259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jferrant
approved these changes
Oct 1, 2024
jferrant
requested changes
Oct 1, 2024
There was a problem hiding this comment.
There is another infinite loop where post_block is called. If you could add that change there too, it would be great!
EDIT: my bad. I could swear there was one in broadcast_signed_block. But I think this was accidentally removed. I know its not part of this PR, but i wonder if it SHOULD infinitely loop in that case as well and then in testing (feel it was removed in a faulty merge), exit prematurely. What do you think?
wileyj
reviewed
Oct 1, 2024
This reverts commit 4a8e819.
jferrant
approved these changes
Oct 2, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes an infinite loop in the signer when
cfg!(test)is active. The rationale for this is that signer integration tests often stop thestacks-nodethreads (via panic, asserts, etc.) on failure before they stop the signer threads. I think this leads to a situation where a test failure loops indefinitely, which in the CI prevents logs from appearing, making diagnosing CI failures and flaky tests very difficult.This PR also removes the first block push invocation -- if the first push in the loop succeeds, there's no need to repush.