Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signers: Use tenure extend timestamp to determine if enough time has passed for a tenure extend #5478

Conversation

jferrant
Copy link
Collaborator

I think it made the most sense to put the calculate tenure extend timestamp code inside the signer db code but I could also put it in the utils if preferred.

…r a tenure extend

Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
@jferrant jferrant requested review from hstove and obycode November 18, 2024 20:38
@jferrant jferrant requested a review from a team as a code owner November 18, 2024 20:38
Copy link
Contributor

@hstove hstove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One small nit that we can just include in a future PR / commit.

stacks-signer/src/signerdb.rs Show resolved Hide resolved
Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
@jferrant jferrant changed the base branch from chore/calc-tenure-idle-timestamp-with-config to feat/time-based-tenure-extend November 18, 2024 22:48
Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
@jferrant jferrant requested a review from a team as a code owner November 19, 2024 18:33
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. I think there is potential later to do some local caching in get_tenure_extend_timestamp.

@jferrant jferrant merged commit 4b60084 into feat/time-based-tenure-extend Nov 19, 2024
11 checks passed
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Nov 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants