-
Notifications
You must be signed in to change notification settings - Fork 677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signers: Use tenure extend timestamp to determine if enough time has passed for a tenure extend #5478
Signers: Use tenure extend timestamp to determine if enough time has passed for a tenure extend #5478
Conversation
…r a tenure extend Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! One small nit that we can just include in a future PR / commit.
Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
…acks-network/stacks-core into feat/signers-allow-time-based-tenure-extends
Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM. I think there is potential later to do some local caching in get_tenure_extend_timestamp
.
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
I think it made the most sense to put the calculate tenure extend timestamp code inside the signer db code but I could also put it in the utils if preferred.