Fix/stackerdb audit coinfabrik #5523
Merged
+255
−92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t-replicas if given
…ate_neighbors false by default
jferrant
previously approved these changes
Dec 3, 2024
jbencin
reviewed
Dec 3, 2024
jbencin
reviewed
Dec 3, 2024
jbencin
previously approved these changes
Dec 3, 2024
…tacks-network/stacks-core into fix/stackerdb-audit-coinfabrik
jbencin
approved these changes
Dec 4, 2024
obycode
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements all of Coinfabrik's StackerDB audit recommendations.
Nothing major was found. The only changes are:
Allow
hint-replicasto be locally overridden, so a StackerDB smart contract can't force subscribed nodes to connect to non-replicas (such as hosts on a private network, or a DoS target)Set
private_neighborstofalseby default (cc @CharlieC3 @deantchi @wileyj so you're aware of this config default)Only count authenticated outbound StackerDB replicas when calculating the broadcast probability for a StackerDB inventory or chunk
cc @will-corcoran