Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite toString to match Node internals #23

Merged
merged 8 commits into from
Sep 14, 2019
Merged

Rewrite toString to match Node internals #23

merged 8 commits into from
Sep 14, 2019

Conversation

niftylettuce
Copy link
Contributor

This closes #21 and #22, and rewrites the toString method to output a stack trace format that more closely resembles Node internals.

Ref: https://github.com/nodejs/node/blob/b6bfc193788b1838bee73d584fe089e1104b9f88/src/node_errors.cc#L142-L175

@niftylettuce
Copy link
Contributor Author

The travis build failed due to an apt-get install failure of google-chrome (not related to this code).

@niftylettuce
Copy link
Contributor Author

I've tested this on my end, all is fixed and ready for merge!

@niftylettuce niftylettuce mentioned this pull request Sep 13, 2019
Closed
@eriwen eriwen self-assigned this Sep 14, 2019
@eriwen eriwen merged commit 1352264 into stacktracejs:master Sep 14, 2019
@eriwen eriwen mentioned this pull request Sep 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eriwen eriwen

Labels
a:feature
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Given an array of stack frames, convert to V8 stack trace stack prop
2 participants
@niftylettuce @eriwen