Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Best practices #14

Closed
jbants opened this issue Aug 3, 2021 · 1 comment · Fixed by #15
Closed

Best practices #14

jbants opened this issue Aug 3, 2021 · 1 comment · Fixed by #15
Assignees
@cuttlefish
Labels
bug Something isn't working

Comments

@jbants
Copy link
Contributor

jbants commented Aug 3, 2021

Describe the bug
Following best practices, the STAC collection should be collection.json

To reproduce
scripts/stac nrcanlandcover create-collection -d ./examples/collection.json

Expected behavior
STAC collection should be collection.json

Additional context
https://github.com/radiantearth/stac-spec/blob/master/best-practices.md#static-catalogs
@jbants jbants added the bug Something isn't working label Aug 3, 2021
@jbants jbants self-assigned this Aug 3, 2021
@cuttlefish
Copy link
Member

-d takes a directory, not a filename.
But it does produce an incorrect name.

@cuttlefish cuttlefish mentioned this issue Aug 3, 2021
Merged
5 tasks
@jbants jbants assigned cuttlefish and unassigned jbants Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cuttlefish cuttlefish

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Collection filename should be collection.json stactools-packages/nrcan-landcover
2 participants
@cuttlefish @jbants