Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collection filename should be collection.json #15

Merged
merged 2 commits into from
Aug 3, 2021
Merged

Collection filename should be collection.json #15

merged 2 commits into from
Aug 3, 2021

Conversation

cuttlefish
Copy link
Member

@cuttlefish cuttlefish commented Aug 3, 2021 •
edited
Loading

Closes #14

PR checklist:

  • Code is formatted (run scripts/format).
  • Code lints properly (run scripts/lint).
  • Tests pass (run scripts/test).
  • Documentation has been updated to reflect changes, if applicable.
  • Changes are added to the CHANGELOG.

jbants
jbants approved these changes Aug 3, 2021
View reviewed changes
Copy link
Contributor

@jbants jbants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@cuttlefish cuttlefish merged commit 54df35f into main Aug 3, 2021
@cuttlefish cuttlefish deleted the fix/catalog-file-name branch August 3, 2021 18:27
cuttlefish added a commit that referenced this pull request Aug 10, 2021
@cuttlefish
Update changelog for #15
df0d101
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbants jbants jbants approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Best practices
2 participants
@cuttlefish @jbants