Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PC backports sentinel3: geometry cleanup #17

Conversation

ircwaves
Copy link
Contributor

Description:
This builds on #15 and adds the common geometry repair strategies from PC to stactools:

  • ensure counter-clockwise winding
  • handle antimeridian crossings
  • round precision of geometric values to 4 decimal places

PR checklist:

  • Code is formatted (run scripts/format).
  • Code lints properly (run scripts/lint).
  • Tests pass (run scripts/test).
  • Documentation has been updated to reflect changes, if applicable.
  • Changes are added to the CHANGELOG.

@ircwaves ircwaves requested a review from gadomski June 15, 2023 20:20
@gadomski
Copy link
Contributor

FYI @ircwaves I'm going to hold off on a review here until #16 lands, so I can see a clean diff of this PR's changes.

@ircwaves ircwaves force-pushed the pc-backports-sentinel3-geometry-cleanup branch from b450ce7 to 9beae59 Compare June 20, 2023 14:52
setup.cfg Outdated Show resolved Hide resolved
@ircwaves ircwaves merged commit 604505a into stactools-packages:main Jun 22, 2023
@ircwaves ircwaves deleted the pc-backports-sentinel3-geometry-cleanup branch June 29, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants