added passwordoption, advanced user interaction and changed subdir #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svoeth
changed the title
svoeth
changed the title
added room prefix to prevent room hijacking
|
I would love to see this in the upstream. On our BBB we successfully integrated your modifications. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expanded bbb-easy-join to accept user set passwords and to give some more insides if something went wrong. It is also possible to roll out bbb-easy-join next to greenlight by changing the subdirectory and default port.
You can test this version on senfcall.de (german version in german branch. Actual development in private gitlab - just copy and pasted current master here)
Passwordoption (a606fe2)
If no password is set the usabilty stays the same (1st user gets mod rights).
New:
If password ist set you have to provide the correct password to join. Only moderators will get the link to the meeting and also the password shown in welcome message. They will also get a second password which allows to join as moderator.
If the wrong password is provided an information will be shown.
Userinformation and operabilty (a606fe2)
New:
If you visit /b/RoomName and RoomName does not exist you will be informed about the missing room and you are able to create it with one click.
New:
If you try to create an existing room, you will be informed and asked if you want to create another room or join the existing room.
New:
In all three cases there is a slow delay of 1-2seconds to prevent simple bruteforce attacks (scriptkiddies). Won't hold off good attackers, but better than nothing :)
Added possibilty to run next to greenlight
New:
Changed default Port and subdirectory to make it possible to run bbb-easy-join next to greenlight
Room prefix
New:
(c6a2f72): Room now get an internal prefix ("easy-"). This way it is not possible to (accidentally) hijack a room which is for example "reserved" by greenlight.
(1cac515): bugfix
README and docs
(a606fe2): Adapted README and overview.png to inform about the new functions and also added some info. Github path in README has to be changed before merge (svoeth -> stadtulm)
(8ba5c3e): Expanded README for new features
(9dba216): Added instructions to change the sudirectory