-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade/gatsby 5 #276
base: staging
Are you sure you want to change the base?
Upgrade/gatsby 5 #276
Conversation
thanks for starting this, @Woozl ! when clean start fresh with an
do i need to bump my Node version for running this maybe? |
@mbwatson yes, the minimum supported Node version is now v18 |
thanks, that did it. i do have to use the nothing exploded! 😅 but there is at least some cleanup around all those ESLint warnings about PascalCasing component names and naming a bunch of anonymous arrow functions, but all looks good at first glance. i will be able to do more thorough testing later today or tomorrow. hopefully other reviewers can weigh in on their experience, too. |
oops saw your comment after I sent this, glad you figured it out @mbwatson oh another thing to note for the fresh install if you're getting peer dependency errors is to use the npm i --legacy-peer-deps Looks like this module: This may work to fix that "peerDependencies": {
- "react": "^16.8.0",
- "react-dom": "^16.8.0"
+ "react": ">=16.8.0",
+ "react-dom": ">=16.8.0"
}, I think it's fine to use the flag, just annoying |
thanks! i don't think we're actually using my accessible accordion anymore 😢, so that dependency could safely go away |
@mwatson/react-accessible-accordion gatsby-plugin-offline react-table
Nothing seems to have blown up! 🤞 I only upgraded the gatsby-plugin packages, react, and styled-components (it was throwing an error otherwise). I took a look over as much as I could so see if anything broke, but definitely the more eyes the better.